feat(cloudflare): map service tokens to user subjects - #1610
Open
timkley wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common_nameto a human Accesssubmemberrole, without copied email, admin, or group claimsContext
Cloudflare service-token JWTs contain a client
common_name, but no humansubor email. That makes a headless MCP client a separate Executor account, so it cannot use the human's personal connections.ACCESS_SERVICE_TOKEN_SUBJECTSadds an explicit mapping at the Access identity boundary. It changes only the account ID used for user-owned data. Mapped and unmapped service tokens remain members and never inherit the mapped user's email, admin role, or groups.Verification
bun run format:checkbun run lintbun run typecheckcd apps/host-cloudflare && bun run test(29 tests)The full repository test run found two unrelated parallel-run flakes in
stdio-integration.test.tsand one OpenAPI form-body test. Each failing test passed in isolation.